8000 chore: migrate from `not(in(collection))` to `e -> !collection.contains(e)`. by eamonnmcmanus · Pull Request #3826 · googleapis/sdk-platform-java · GitHub
[go: up one dir, main page]
Skip to content

chore: migrate from not(in(collection)) to e -> !collection.contains(e). #3826

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: migrate from not(in(collection)) to e -> !collection.contains(e). #3826

wants to merge 4 commits into from

Conversation

eamonnmcmanus
Copy link
@eamonnmcmanus eamonnmcmanus commented Jun 2, 2025 •
edited
Loading

Guava's functional types have been obsoleted by the JDK's functional types.

(This reflects a change we are making throughout Google's internal source code.)

@eamonnmcmanus
chore: migrate from not(in(collection)) to `e -> !collection.contai…
01b3370 
…ns(e)`.

Guava's functional types have been obsoleted by the JDK's functional types.

(This reflects a change we are making throughout Google's internal source code.)
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 2, 2025
@blakeli0
Copy link
Collaborator
blakeli0 commented Jun 4, 2025

Hi @eamonnmcmanus, thanks for contributing! Is there an internal issue we can understand more about the background?

@eamonnmcmanus
Copy link
Author

Hi @eamonnmcmanus, thanks for contributing! Is there an internal issue we can understand more about the background?

Yes, http://b/419373312. I or @kluever can supply more background if needed.

@blakeli0
Copy link
Collaborator
blakeli0 commented Jun 4, 2025

Hi @eamonnmcmanus, thanks for contributing! Is there an internal issue we can understand more about the background?

Yes, http://b/419373312. I or @kluever can supply more background if needed.

Thanks! I know there are Javadoc to discourage people from using them already, but are they going to be deprecated as well so that it easily reminds us to not use them in the future?

@blakeli0
Copy link
Collaborator
blakeli0 commented Jun 4, 2025

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eamonnmcmanus @blakeli0
0