8000 fix(spring): add javadoc comments for properties by emmileaf · Pull Request #1171 · googleapis/sdk-platform-java · GitHub
[go: up one dir, main page]
Skip to content

fix(spring): add javadoc comments for properties #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 21, 2022
Merged

fix(spring): add javadoc comments for properties #1171

merged 2 commits into from
Dec 21, 2022

Conversation

emmileaf
Copy link
Contributor
@emmileaf emmileaf commented Dec 20, 2022 •
edited
Loading

This PR is a follow-up on GoogleCloudPlatform/spring-cloud-gcp#1364 (comment), and adds Javadoc comments to configurable properties.

@emmileaf emmileaf mentioned this pull request Dec 20, 2022
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@emmileaf emmileaf added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Dec 20, 2022
@emmileaf emmileaf marked this pull request as ready for review December 20, 2022 22:25
@emmileaf emmileaf requested a review from a team as a code owner December 20, 2022 22:25
@emmileaf emmileaf merged commit 7f550b5 into autoconfig-gen-draft2 Dec 21, 2022
@emmileaf emmileaf deleted the spring-properties-javadoc-2 branch December 21, 2022 22:09
@emmileaf emmileaf mentioned this pull request Dec 21, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhumin8 zhumin8 zhumin8 approved these changes

@meltsufin meltsufin meltsufin approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp

Assignees
No one assigned
Labels
spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmileaf @zhumin8 @meltsufin
0