chore: relocate gapic-generator-java pom.xml to subfolder #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changes look good to me. The bazel build is failing though, if all the checks are passing, we could merge it in. |
meltsufin
reviewed
Nov 30, 2022
| private static final String GOLDENFILES_DIRECTORY = | ||
| "src/test/java/com/google/api/generator/engine/goldens/"; | ||
| "../src/test/java/com/google/api/generator/engine/goldens/"; |
There was a problem hiding this comment.
Would it be possible to change the working directory for surefire or failsafe instead?
There was a problem hiding this comment.
Good idea. I'll give it a try.
There was a problem hiding this comment.
This suggestion gets bonus points for both simplifying the PR and fixing the bazel build.
|
Kudos, SonarCloud Quality Gate passed!
|
meltsufin
approved these changes
Nov 30, 2022
blakeli0
approved these changes
Nov 30, 2022
burkedavison
added a commit
that referenced
this pull request
Dec 8, 2022
* ci(showcase): add showcase IT coverage * ci(showcase): rework showcase coverage for combined report * chore(deps): update dependency gradle to v7.6 (#1101) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gradle](https://gradle.org) ([source](https://togithub.com/gradle/gradle)) | minor | `7.5.1` -> `7.6` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzQuMzQuMSJ9--> * ci(showcase): debug showcase integration coverage report in sonar * ci(showcase): remove duplicate bazel coverage stage * ci(showcase): invoke sonar after integration tests * ci(showcase): debug with maven and sonar * ci(showcase): attempt sonar workaround for lcov coverage parsing * chore(showcase): create maven showcase module * chore: relocate gapic-generator-java pom.xml to subfolder * fix: ensure all tests work with new project structure * fix: set surefire working directory, and revert source adjustments * fix: formatter * chore: relocate gapic-generator-java pom.xml to subfolder (#1105) * chore: relocate gapic-generator-java pom.xml to subfolder * fix: ensure all tests work with new project structure * fix: set surefire working directory, and revert source adjustments * fix: formatter * chore: update showcase maven module to generate and verify golden source * chore: update showcase maven module to generate and verify golden source * chore: add showcase golden source to maven submodule * chore: upload two coverage reports to sonar * chore: show proto folder contents during verify_proto * fix: only diff proto src/main/java, ignoring src/main/proto * chore(main): release 2.11.0 (#1081) Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> * chore: change showcase version to 0.0.1-SNAPSHOT * chore: add mvn -version to sonar workflow * fix: set showcase client to 0.0.1-SNAPSHOT * fix: explicitly set shade plugin output directory * chore: remove aggregator from build * fix: coverage report locations * fix: skip linting on generated showcase files * fix: sonar coverage for non-standard directory structure (#1108) * fix: exclude generated showcase from license header check * fix: single-line 'find' syntax * fix: use provided ignore flag * ci(showcase): rework github actions for showcase golden and integration tests * ci(showcase): simplify sonar github actions workflow * ci(showcase): remove showcase from /test/integration golden suite * ci(showcase): simplify showcase invocation * fix(showcase): ensure generated showcase protos are not deleted * ci(showcase): update workflow and documentation for showcase * ci(showcase): disable snippet-bot for generated showcase client * ci(showcase): disable snippet-bot for showcase (#1113) Co-authored-by: Mend Renovate <bot@renovateapp.com> Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
* chore: relocate gapic-generator-java pom.xml to subfolder * fix: ensure all tests work with new project structure * fix: set surefire working directory, and revert source adjustments * fix: formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@blakeli0 : This is the minimum number of edits needed to make the project work with a relocated
pom.xml.Let's discuss whether you'd prefer to have this stay in its own branch for now.