fix(spring): fix and refactor class nam 8000 es for autoconfiguration and properties #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhumin8
reviewed
Nov 15, 2022
| @@ -138,7 +138,7 @@ static String buildAutoConfigRegistrationString(GapicContext context) { | |||
| service -> | |||
| sb.add( | |||
| String.format( | |||
| "%s.spring.%sSpringAutoConfig", service.pakkage(), service.name()))); | |||
| "%s.spring.%sSpringAutoConfiguration", service.pakkage(), service.name()))); | |||
There was a problem hiding this comment.
Good catch. Now I wonder if it's worth to extract this name and the properties class name into a util, so in case we change it in the future, they stay consistent?
There was a problem hiding this comment.
That's a good idea - I'll work on refactoring in this PR to something more future-proof. This is likely the only issue that will be patched here (since all of the other items are being addressed separately) so I'll update the description and title when ready for review.
|
Kudos, SonarCloud Quality Gate passed! |
zhumin8
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
<Service>SpringAutoConfigto<Service>SpringAutoConfiguration<Service>SpringAutoConfigurationand<Service>SpringPropertiesclasses into utils to reduce potential inconsistency in the composer codeThis PR was originally opened to track and (patch where applicable) some missing items (from compiling/testing against the generated module for language):
Fixing through separate PRs:
Durationcannot be implicitly converted from String2022instead of2022-2022patterncom.google.api.gax.httpjson.InstantiatingHttpJsonChannelProviderandorg.threeten.bp.Durationjava_gapic.bzlshould call formatter to remove these