ci: Add showcase build to CI test steps #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
reviewed
Nov 11, 2022
blakeli0
reviewed
Nov 11, 2022
blakeli0
reviewed
Nov 11, 2022
blakeli0
reviewed
Nov 11, 2022
blakeli0
requested changes
Nov 11, 2022
…showcase # Conflicts: # src/main/java/com/google/api/generator/gapic/composer/grpc/ServiceClientTestClassComposer.java
blakeli0
reviewed
Nov 14, 2022
blakeli0
reviewed
Nov 14, 2022
...ain/java/com/google/showcase/v1beta1/compliance/create/SyncCreateSetCredentialsProvider.java
Show resolved
Hide resolved
blakeli0
reviewed
Nov 14, 2022
blakeli0
reviewed
Nov 14, 2022
… /test/integration copy.
blakeli0
approved these changes
Nov 17, 2022
Base automatically changed from
bugfix/support-nested-argument-method-signatures
to
main
November 18, 2022 14:19
# Conflicts: # src/main/java/com/google/api/generator/gapic/composer/grpc/ServiceClientTestClassComposer.java
|
Kudos, SonarCloud Quality Gate passed!
|
suztomo
pushed a commit
that referenced
this pull request
Dec 16, 2022
* ci: add showcase testing * fix: Support testing nested argument method signatures and 'double' field assertions * ci: Add showcase build to CI * fix: Run formatter * fix: Remove unused parameter. Rename variable. * fix: inline commit.gapic_showcase rather than using PROPERTIES.bzl * fix: showcase no longer generates samples, and 'rest_numeric_enums' is now true * chore: Add initial golden showcase files * fix: exclude .DS_Store from golden files directories * fix: Support testing nested argument method signatures and 'double' field assertions * fix: DRY refactor for consistent double+float assertions * fix: Remove unused parameter. * fix: update showcase golden files for 0.0001 delta in assertEquals * fix: remove unnecessary load of PROPERTIES.bzl * ci: remove 'Showcase Tests' ci stage until differentiated from existing 'Integration Tests' * fix(showcase): remove duplicate test suite in /test/showcase, keeping /test/integration copy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces showcase client generation during
bazel test //test/integration:showcase.