feat(SpringGen): adding extra annotations at the SpringComposer step for all Spring classes generated
#1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmileaf
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
LGTM! A couple of curiosities on the BetaApi annotation:
- Would it be helpful to provide a context string, like
@BetaApi(“Autogenerated Spring autoconfiguration is not yet stable”)? - Assuming this blanket BetaApi annotation will eventually be removed here: would we only intend to support Spring autoconfig for stable API client libraries, or could there be cases where this annotation is needed to distinguish such things from upstream?
|
|
Kudos, SonarCloud Quality Gate passed! |
diegomarquezp
pushed a commit
that referenced
this pull request
Nov 2, 2022
…p for all Spring classes generated (#1062) this pr: - adds a @BetaApi annotation for each class composed in SpringComposer - also moves the @generated("by gapic-generator-java") annotation to SpringComposer for consistency. (this annotation was missing for the properties class composer.) - Updating annotations in SpringComposer level for the ones that applies to all classes makes it easier for future changes when needed.
diegomarquezp
added a commit
that referenced
this pull request
Nov 3, 2022
* feat(SpringGen): adding extra annotations at the `SpringComposer` step for all Spring classes generated (#1062) this pr: - adds a @BetaApi annotation for each class composed in SpringComposer - also moves the @generated("by gapic-generator-java") annotation to SpringComposer for consistency. (this annotation was missing for the properties class composer.) - Updating annotations in SpringComposer level for the ones that applies to all classes makes it easier for future changes when needed. * fix(test): remove wrong files from rebase action * fix(format): linting * fix(license): add license header to prop comm comp * fix(test): restore ComposerTest * fix: format files Co-authored-by: Min Zhu <zhumin@google.com>
suztomo
pushed a commit
that referenced
this pull request
Mar 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.easymock:easymock](http://easymock.org) ([source](https://togithub.com/easymock/easymock)) | `5.0.1` -> `5.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yNC4wIiwidXBkYXRlZEluVmVyIjoiMzQuMjQuMCJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr:
@BetaApiannotation for each class composed inSpringComposer@Generated("by gapic-generator-java")annotation toSpringComposerfor consistency. (this annotation was missing for the properties class composer.)Updating annotations in
SpringComposerlevel for the ones that applies to all classes makes it easier for future changes when needed.