8000 [WIP] Use django/django in build script by FirePing32 · Pull Request #561 · googleapis/python-spanner-django · GitHub
[go: up one dir, main page]
Skip to content

[WIP] Use django/django in build script #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[WIP] Use django/django in build script #561

wants to merge 4 commits into from

Conversation

FirePing32
Copy link
@FirePing32 FirePing32 commented Dec 1, 2020 •
edited
Loading

fixes: #485

WIP: A new adaption of #527

@FirePing32 FirePing32 requested a review from a team as a code owner December 1, 2020 17:10
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Dec 1, 2020
@google-cla
Copy link
google-cla bot commented Dec 1, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 1, 2020
@FirePing32
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 1, 2020
@FirePing32
Copy link
Author

@c24t Although I am still working on this, shouldn't we add a commitment.config.js to validate commits ?

@c24t
Copy link
Contributor
c24t commented Dec 1, 2020

shouldn't we add a commitment.config.js to validate commits ?

There's a googleapis checker for this, AFAIK this is configured the same way for all repos in the org. You can see the check in action on this PR above.

image

@c24t
Copy link
Contributor
c24t commented Dec 1, 2020

FYI you can open PRs as drafts if they're WIP and not ready for review: https://github.blog/2019-02-14-introducing-draft-pull-requests/.

@c24t
Copy link
Contributor
c24t commented Jan 29, 2021

Closing as inactive. To fix #485 we need to patch django in tests (or host our own patched version of django), not just s/timgraham/django/.

@c24t c24t closed this Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cleanup] Don't use django fork in build script
2 participants
@FirePing32 @c24t
0