8000 chore: Code refactoring to follow common Google API scheme by mf2199 · Pull Request #482 · googleapis/python-spanner-django · GitHub
[go: up one dir, main page]
Skip to content

chore: Code refactoring to follow common Google API scheme #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 26 commits into from
Closed

chore: Code refactoring to follow common Google API scheme #482

wants to merge 26 commits into from

Conversation

mf2199
Copy link
Contributor
@mf2199 mf2199 commented Sep 7, 2020 •
edited
Loading

Change list:

  1. django_spanner folder renamed to spanner_django and moved inside google/cloud/;
  2. spanner_dbapi folder moved inside google/cloud/;
  3. Invalidated references updated to reflect the above changes;
  4. Relevant updates to noxfile.py.

While working on the build errors, this PR is kept as a draft.

larkee and others added 13 commits May 26, 2020 14:09
@larkee
feat: release 2.2a0 (googleapis#457)
11222db 
Release-As: 2.2.a0

Co-authored-by: larkee <larkee@users.noreply.github.com>
@mf2199
feat: [WIP] The first stage of nox implementation (googleapis#468)
5551b58
feat: refactor connect() function, cover it with unit tests (googleap…
bfde221 
…is#462)
@mf2199
feat: Stage 2 of nox implementation - adding docs target (googlea…
e017901 
…pis#473)
@c24t
fix: Fix black, isort compatibility (googleapis#469)
144bdc2
@mf2199
feat: Stage 3-4 of nox implementation - adding auto-format targets (g…
7a1f6a6 
…oogleapis#478)
@mf2199
feat: Stage 5 of nox implementation - adding coverage targets (goog…
acd9209 
…leapis#479)
feat: cursor must detect if the parent connection is closed (googleap…
6028f88 
…is#463)
@mf2199
chore: folder django_spanner renamed to spanner_django
f51960b
@mf2199
chore: spanner_django moved to google/cloud/
c28122f
@mf2199
fix: links in noxfile.py
635e610
@mf2199
chore: folder spanner_dbapi moved to google/cloud/
f920c8d
@mf2199
chore: fixed references + cleanup
1cb4712
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2020
@mf2199 mf2199 requested review from IlyaFaer, c24t and paul1319 September 7, 2020 22:59
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Sep 8, 2020
IlyaFaer
IlyaFaer reviewed Sep 8, 2020
View reviewed changes
Copy link
Contributor
@IlyaFaer IlyaFaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay

@c24t
Copy link
Contributor
c24t commented Sep 8, 2020

This PR changes the distribution name from django-google-spanner to google-cloud-spanner-django to match the other googleapis projects. Thankfully this project hasn't been released on PyPI yet, so we don't have to worry about deprecating the old name.

It also changes the package namespace. Now instead of a single top-level django_spanner we've got two new namespaces under the shared google.cloud: google.cloud.spanner_django and google.cloud.spanner_dbapi. This is (1) and (2) in the description, I just wanted to make it explicit that we're using namespace packages here and this isn't just a directory move.

Both great changes, and both following the conventions of the other python repos.

@c24t
Copy link
Contributor
c24t commented Sep 10, 2020

After talking to @skuruppu it sounds like we should keep the django-google-spanner distribution name:

@mf2199 mf2199 marked this pull request as ready for review September 10, 2020 14:26
This was referenced Sep 11, 2020
Closed
Merged
@c24t c24t force-pushed the master branch 5 times, most recently from 37b9a88 to 803ad0a Compare September 15, 2020 19:51
@IlyaFaer
Copy link
Contributor

@mf2199, this PR looks not very actual - most part is already merged. Should we close it?

@IlyaFaer
Copy link
Contributor
IlyaFaer commented Oct 6, 2020

Closing as this PR seems to be old, and its changes were merged with other smaller PRs

@IlyaFaer IlyaFaer closed this Oct 6, 2020
@IlyaFaer IlyaFaer deleted the refactor branch February 1, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaFaer IlyaFaer IlyaFaer left review comments

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mf2199 @c24t @IlyaFaer @larkee
0