8000 tests: revert testing against prerelease deps on Python 3.9 by tseaver · Pull Request #527 · googleapis/python-spanner · GitHub
[go: up one dir, main page]
Skip to content

tests: revert testing against prerelease deps on Python 3.9 #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

tests: revert testing against prerelease deps on Python 3.9 #527

merged 1 commit into from
Aug 18, 2021

Conversation

tseaver
Copy link
Contributor
@tseaver tseaver commented Aug 17, 2021

Consensus from today's meeting is that testing against prereleases needs to happen outside the normal presubmit path.

Reverts only part of PR #479.

@tseaver
tests: revert testing prerelease deps on Python 3.9
431cde1 
Consensus from today's meeting is that testing against prereleases needs
to happen outside the normal presubmit path.

Reverts only part of PR #479.
@tseaver tseaver requested a review from a team as a code owner August 17, 2021 18:13
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Aug 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2021
@tseaver tseaver changed the title tests: revert testing prerelease deps on Python 3.9 tests: revert testing against prerelease deps on Python 3.9 Aug 17, 2021
@tseaver tseaver mentioned this pull request Aug 17, 2021
Closed
@larkee larkee added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Aug 17, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 17, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
@larkee larkee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your requ 8000 ired status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2021
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 18, 2021
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 33f00ab into master Aug 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the 479-revert-prerelease-py39 branch August 18, 2021 14:26
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

@tswast tswast Awaiting requested review from tswast

@crwilcox crwilcox Awaiting requested review from crwilcox

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @larkee @yoshi-kokoro
0