8000 perf: Skip gRPC trailers for StreamingRead & ExecuteStreamingSql by sakthivelmanii · Pull Request #1385 · googleapis/python-spanner · GitHub
[go: up one dir, main page]
Skip to content
Dismiss alert

perf: Skip gRPC trailers for StreamingRead & ExecuteStreamingSql #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

perf: Skip gRPC trailers for StreamingRead & ExecuteStreamingSql #1385

wants to merge 11 commits into from

Conversation

sakthivelmanii
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@sakthivelmanii sakthivelmanii requested review from a team as code owners June 6, 2025 14:46
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Jun 6, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jun 9, 2025
olavloite
olavloite previously approved these changes Jun 9, 2025
View reviewed changes
tests/mockserver_tests/test_basics.py Outdated
)


class TestBasics(MockServerTestBase):
def setUp(self):
super().setUp()
super().setup_class()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to call setup_class() for each test method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me remove this. This is needed only when I am running individual tests in PyCharm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@bhatt4982 bhatt4982

Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakthivelmanii @olavloite @bhatt4982
0