-
Notifications
You must be signed in to change notification settings - Fork 56
Closed
Labels
api: loggingIssues related to the googleapis/python-logging API.Issues related to the googleapis/python-logging API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Description
We have two methods of interacting with the API backend: gRPC (default) and HTTP (used when client is created with google.cloud.logging.Client(_use_grpc=0)
or DISABLE_GRPC
is set).
This is implemented using two _*API implementations: One in _http.py and the other in _gapic.py. It looks like in some cases, they return different values (_http returns a page iterator object directly, while _gapic often converts it to a generator. This confuses users who expect high-level APIs to act consistently regardless of the implementation used.
I suggest we refactor _http.py to be consistent with _gapic.py, and add tests to make sure they act consistently
Metadata
Metadata
Assignees
Labels
api: loggingIssues related to the googleapis/python-logging API.Issues related to the googleapis/python-logging API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.