8000 chore: code clean up by slowy07 · Pull Request #351 · googleapis/python-dialogflow · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Dec 17, 2023. It is now read-only.

chore: code clean up #351

Merged
merged 4 commits into from
Jul 26, 2021
Merged

chore: code clean up #351

merged 4 commits into from
Jul 26, 2021

Conversation

slowy07
Copy link
Contributor
@slowy07 slowy07 commented Jul 26, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #350 🦕

@slowy07 slowy07 requested a review from a team as a code owner July 26, 2021 01:31
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 26, 2021
@product-auto-label product-auto-label bot added the api: dialogflow Issues related to the googleapis/python-dialogflow API. label Jul 26, 2021
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 26, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 26, 2021
@parthea parthea changed the title Fixing over-indented and should 'not in' chore: code clean up Jul 26, 2021
parthea
parthea approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor
@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @slowy07 !

@parthea parthea added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 61123e7 into googleapis:master Jul 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 26, 2021
@slowy07
Copy link
Contributor Author
slowy07 commented Jul 26, 2021

LGTM, Thanks @slowy07 !

thank you so much @parthea !

@parthea parthea mentioned this pull request Jul 26, 2021
Merged
gcf-merge-on-green bot pushed a commit to googleapis/gapic-generator-python that referenced this pull request Jul 26, 2021
@parthea
chore: clean up fixup scripts (#963)
1ba3b73 
Incorporate changes from googleapis/python-dialogflow#351 in templated fixup script files
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@parthea parthea parthea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: dialogflow Issues related to the googleapis/python-dialogflow API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

continuation line over-indented for hanging indent, and lambda logical

3 participants

@slowy07 @parthea @yoshi-kokoro
0