8000 refactor: Switch explode node to use column offsets by TrevorBergeron · Pull Request #978 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

refactor: Switch explode node to use column offsets #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TrevorBergeron merged 1 commit into from
Sep 11, 2024
Merged

refactor: Switch explode node to use column offsets #978

TrevorBergeron merged 1 commit into from
Sep 11, 2024

Conversation

@TrevorBergeron
Copy link
Contributor
@TrevorBergeron TrevorBergeron commented Sep 11, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners September 11, 2024 20:25
sycai
sycai approved these changes Sep 11, 2024
View reviewed changes
bigframes/core/__init__.py
"""
return ArrayValue(nodes.RandomSampleNode(self.node, fraction))

def get_offset_for_name(self, name: str):
Copy link
Contributor
@sycai sycai Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: get_name_offset ?

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 11, 2024
@TrevorBergeron TrevorBergeron merged commit 40113d8 into main Sep 11, 2024
@TrevorBergeron TrevorBergeron deleted the bfet_offsets branch September 11, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sycai sycai sycai approved these changes

Assignees

@shobsi shobsi

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TrevorBergeron @sycai @shobsi
0