10BC0 test: add CSV sample data file for testing by chelsea-lin · Pull Request #938 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

test: add CSV sample data file for testing #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chelsea-lin merged 3 commits into from
Aug 30, 2024
Merged

test: add CSV sample data file for testing #938

chelsea-lin merged 3 commits into from
Aug 30, 2024

Conversation

@chelsea-lin
Copy link
Contributor
@chelsea-lin chelsea-lin commented Aug 29, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue(internal issue 361420947) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 361420947 🦕

@chelsea-lin chelsea-lin requested a review from GarrettWu August 29, 2024 17:53
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels Aug 29, 2024
@chelsea-lin chelsea-lin marked this pull request as ready for review August 29, 2024 18:30
@chelsea-lin chelsea-lin requested review from a team as code owners August 29, 2024 18:30
@chelsea-lin chelsea-lin requested a review from Genesis929 August 29, 2024 18:30
@chelsea-lin chelsea-lin enabled auto-merge (squash) August 29, 2024 19:32
@chelsea-lin chelsea-lin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2024
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2024
@chelsea-lin chelsea-lin merged commit 7472a11 into main Aug 30, 2024
@chelsea-lin chelsea-lin deleted the main_chelsealin_addcsvfile branch August 30, 2024 22:14
arwas11 pushed a commit that referenced this pull request Sep 3, 2024
@chelsea-lin @arwas11
test: add CSV sample data file for testing (#938)
a602c7d 
* test: add CSV sample data file for testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929 Genesis929 is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@junyazhang junyazhang

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chelsea-lin @GarrettWu @junyazhang @bigframes-bot
0