8000 fix: remove a usage of the `resource` package when not available, such as on Windows by tswast · Pull Request #681 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

fix: remove a usage of the resource package when not available, such as on Windows #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 4 commits into from
May 15, 2024
Merged

fix: remove a usage of the resource package when not available, such as on Windows #681

tswast merged 4 commits into from
May 15, 2024

Conversation

@tswast
Copy link
Collaborator
@tswast tswast commented May 10, 2024

Towards internal issue 339769193.

Note: I'm still working on getting a Windows Python dev environment setup, but this should address at least one known problem. I aim to follow-up with automated tests on Windows, too.

🦕

@tswast tswast requested review from a team as code owners May 10, 2024 21:51
@tswast tswast requested a review from GarrettWu May 10, 2024 21:51
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels May 10, 2024
@tswast tswast mentioned this pull request May 10, 2024
Merged
@tswast
Copy link
Collaborator Author
tswast commented May 13, 2024

I verified manually that import bigframes.pandas now works on Windows. I'm working on automated testing to make sure all functionality works and we don't regress.

@tswast tswast enabled auto-merge (squash) May 15, 2024 14:23
@tswast tswast merged commit 96243f2 into main May 15, 2024
@tswast tswast deleted the b339769193-windows branch May 15, 2024 19:34
@release-please release-please bot mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
< 7BFF div class="discussion-sidebar-item sidebar-assignee js-discussion-sidebar-item position-relative js-socket-channel js-updatable-content" data-team-hovercards-enabled data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjE4NjQ1NzY3NjUiLCJ0IjoxNzY2Nzg1MzE5fQ==--20e25d708f93b3a1eeb95bf3229a8e2c1780429313051576e40bd88602b5ff1f" data-gid="PR_kwDOJ8q-G85vIy79" data-url="/googleapis/python-bigquery-dataframes/issues/681/show_partial?partial=pull_requests%2Fsidebar%2Fshow%2Freviewers" data-channel-event-name="reviewers_updated" >

Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

@GarrettWu GarrettWu Awaiting requested review from GarrettWu GarrettWu is a code owner automatically assigned from googleapis/api-bigquery-dataframe

+1 more reviewer

@ashleyxuu ashleyxuu ashleyxuu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ashleyxuu ashleyxuu

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @TrevorBergeron @ashleyxuu
0