8000 feat: Support `axis=1` in `df.apply` for scalar outputs by shobsi · Pull Request #629 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

feat: Support axis=1 in df.apply for scalar outputs #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shobsi merged 47 commits into from
May 10, 2024
Merged

feat: Support axis=1 in df.apply for scalar outputs #629

shobsi merged 47 commits into from
May 10, 2024

Conversation

@shobsi
Copy link
Contributor
@shobsi shobsi commented Apr 22, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes internal issue 320674749 🦕

@shobsi shobsi requested review from a team as code owners April 22, 2024 17:26
@shobsi shobsi requested a review from DevStephanie April 22, 2024 17:26
@shobsi shobsi removed the request for review from DevStephanie April 22, 2024 17:45
@shobsi shobsi marked this pull request as draft April 22, 2024 17:46
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 22, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Apr 23, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 23, 2024
@shobsi shobsi marked this pull request as ready for review April 24, 2024 21:21
@shobsi shobsi requested a review from TrevorBergeron April 24, 2024 21:22
TrevorBergeron
TrevorBergeron requested changes Apr 25, 2024
View reviewed changes
TrevorBergeron
TrevorBergeron reviewed May 2, 2024
View reviewed changes
@GarrettWu GarrettWu mentioned this pull request May 3, 2024
Closed
TrevorBergeron
TrevorBergeron reviewed May 8, 2024
View reviewed changes
@shobsi shobsi merged commit f6bdc4a into main May 10, 2024
@shobsi shobsi deleted the shobs-rf-arr-in branch May 10, 2024 19:50
@release-please release-please bot mentioned this pull request May 10, 2024
Merged
tswast
tswast reviewed May 17, 2024
View reviewed changes
bigframes/dataframe.py
# in the remote function
# NOTE: Keep in sync with the value converters used in the gcf code
# generated in generate_cloud_function_main_code in remote_function.py
remote_function_supported_dtypes = (
Copy link
Collaborator
@tswast tswast May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd document these limitations, too, right?

Copy link
Contributor Author
@shobsi shobsi Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding in #800

@shobsi shobsi mentioned this pull request Jun 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast left review comments

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

Assignees

@chelsea-lin chelsea-lin

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shobsi @tswast @TrevorBergeron @chelsea-lin
0