8000 feat: Add `ml.metrics.pairwise.paired_manhattan_distance` by ashleyxuu · Pull Request #392 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@ashleyxuu
Copy link
Contributor
@ashleyxuu ashleyxuu commented Feb 26, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal #325978655 🦕

@ashleyxuu ashleyxuu requested a review from GarrettWu February 26, 2024 20:00
@ashleyxuu ashleyxuu requested review from a team as code owners February 26, 2024 20:00
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Feb 26, 2024
@ashleyxuu ashleyxuu force-pushed the ashleyxu-manhattan-distance branch from b23f7fa to 8812be9 Compare February 26, 2024 21:56
Copy link
Contributor
@GarrettWu GarrettWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz update the commit title as well.

@ashleyxuu ashleyxuu merged commit 9d31865 into main Feb 27, 2024
@ashleyxuu ashleyxuu deleted the ashleyxu-manhattan-distance branch February 27, 2024 15:30
@ashleyxuu ashleyxuu changed the title feat: Add ml.metrics.pairwise.manhattan_distance feat: Add ml.metrics.pairwise.paired_manhattan_distance Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0