fix: correct the numeric literal dtype #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
reviewed
Feb 5, 2024
| scalar_expr = ibis.literal(literal, ibis_dtypes.float64) | ||
| elif scalar_expr.type().is_integer(): | ||
| scalar_expr = ibis.literal(literal, ibis_dtypes.int64) | ||
| elif scalar_expr.type().is_decimal(): |
Collaborator
There was a problem hiding this comment.
This would break BIGNUMERIC, I think. We should probably have something that goes to the nearest type. https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types#decimal_types
Like is_decimal and precision < 76, then this otherwise set to the precision and scale for BIGNUMERIC.
Contributor
Author
There was a problem hiding this comment.
good point! thanks!
eb3489e to
68108ac
Compare
68108ac to
f81077a
Compare
TrevorBergeron
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal bug: b/323070618 🦕