chore: add total_bytes_processed to PandasBatches #2052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes internal issue b/443094245
tswast
commented
Sep 4, 2025
| pandas_batches: Iterator[pd.DataFrame], | ||
| total_rows: Optional[int] = 0, | ||
| *, | ||
| total_bytes_processed: Optional[int] = 0, |
Collaborator
Author
There was a problem hiding this comment.
I wonder if this should default to None to indicate cases where query execution didn't happen?
Contributor
There was a problem hiding this comment.
i think a default of None is probably safest? 0 should be a confident statement of zero bytes billed ideally?
Contributor
There was a problem hiding this comment.
I think 0 should be used whenever we are sure we didn't burn any query resources though
TrevorBergeron
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal issue b/443094245
🦕