8000 chore: add logging to bigframes.bigquery functions by sycai · Pull Request #2045 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

chore: add logging to bigframes.bigquery functions #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 5 commits into from
Sep 4, 2025
Merged

chore: add logging to bigframes.bigquery functions #2045

tswast merged 5 commits into from
Sep 4, 2025
+40 −33

Conversation

@sycai
Copy link
Contributor
@sycai sycai commented Sep 3, 2025

Fixes #442659011 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Sep 3, 2025
@sycai sycai requested review from Genesis929 and chelsea-lin and removed request for Genesis929 and chelsea-lin September 3, 2025 17:47
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 3, 2025
@sycai sycai requested a review from tswast September 3, 2025 18:04
@sycai sycai marked this pull request as ready for review September 3, 2025 18:58
@sycai sycai requested review from a team as code owners September 3, 2025 18:58
Genesis929
Genesis929 reviewed Sep 3, 2025
View reviewed changes
bigframes/bigquery/__init__.py
"unix_micros",
"unix_millis",
"unix_seconds",
# geo ops
Copy link
Collaborator
@Genesis929 Genesis929 Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep the comments?

Copy link
Contributor Author
@sycai sycai Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing. Done

@sycai sycai requested a review from Genesis929 September 3, 2025 22:10
tswast
tswast approved these changes Sep 4, 2025
View reviewed changes
Copy link
Collaborator
@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tswast tswast merged commit 200458d into main Sep 4, 2025
25 checks passed
@tswast tswast deleted the sycai_bbq_logs branch September 4, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@chelsea-lin chelsea-lin Awaiting requested review from chelsea-lin

@Genesis929 Genesis929 Awaiting requested review from Genesis929

Assignees

@Genesis929 Genesis929

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sycai @tswast @Genesis929
0