8000 fix: Series.str.isdigit in unicode superscripts and fractions by GarrettWu · Pull Request #1924 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

fix: Series.str.isdigit in unicode superscripts and fractions #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GarrettWu merged 4 commits into from
Jul 21, 2025
Merged

fix: Series.str.isdigit in unicode superscripts and fractions #1924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b541462
fix: Series.str.isdigit in unicode subscripts
GarrettWu May 19, 2025
7f0d28a
Merge remote-tracking branch 'github/main' into garrettwu-isdigit
GarrettWu Jul 21, 2025
1e00ecc
fix test
GarrettWu Jul 21, 2025
bdf4525
Merge remote-tracking branch 'github/main' into garrettwu-isdigit
GarrettWu Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bigframes/core/compile/scalar_op_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,9 +487,9 @@ def isalpha_op_impl(x: ibis_types.Value):

@scalar_op_compiler.register_unary_op(ops.isdigit_op)
def isdigit_op_impl(x: ibis_types.Value):
# Based on docs, should include superscript/subscript-ed numbers
# Tests however pass only when set to Nd unicode class
return typing.cast(ibis_types.StringValue, x).re_search(r"^(\p{Nd})+$")
return typing.cast(ibis_types.StringValue, x).re_search(
r"^[\p{Nd}\x{00B9}\x{00B2}\x{00B3}\x{2070}\x{2074}-\x{2079}\x{2080}-\x{2089}]+$"
)


@scalar_op_compiler.register_unary_op(ops.isdecimal_op)
Expand Down
9 changes: 3 additions & 6 deletions tests/system/small/operations/test_strings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,13 +324,10 @@ def test_isalpha(weird_strings, weird_strings_pd):
)


@pytest.mark.skipif(
"dev" in pa.__version__,
# b/333484335 pyarrow is inconsistent on the behavior
reason="pyarrow dev version is inconsistent on isdigit behavior.",
)
def test_isdigit(weird_strings, weird_strings_pd):
pd_result = weird_strings_pd.str.isdigit()
# check the behavior against normal pandas str, since pyarrow has a bug with superscripts/fractions b/333484335
# astype object instead of str to support pd.NA
pd_result = weird_strings_pd.astype(object).str.isdigit()
bf_result = weird_strings.str.isdigit().to_pandas()

pd.testing.assert_series_equal(
Expand Down
0