8000 refactor: Refactor udf definitions by TrevorBergeron · Pull Request #1814 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

refactor: Refactor udf definitions #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 13, 2025
Merged

refactor: Refactor udf definitions #1814

merged 5 commits into from
Jun 13, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron force-pushed the grand_udf_refactor branch 2 times, most recently from 46ac6ab to 3367b1b Compare June 12, 2025 23:07 8000
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jun 12, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review June 13, 2025 05:05
@TrevorBergeron TrevorBergeron requested review from a team as code owners June 13, 2025 05:05
chelsea-lin
chelsea-lin previously approved these changes Jun 13, 2025
View reviewed changes
Copy link
Contributor
@chelsea-lin chelsea-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! This PR makes new compiler refactor much easier. Thanks!

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jun 13, 2025
@TrevorBergeron TrevorBergeron merged commit f984381 into main Jun 13, 2025
24 checks passed
@TrevorBergeron TrevorBergeron deleted the grand_udf_refactor branch June 13, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@ivansmf ivansmf

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @chelsea-lin @ivansmf
0