8000 refactor: Polars scalar op uses singledispatchmethod by TrevorBergeron · Pull Request #1807 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

refactor: Polars scalar op uses singledispatchmethod #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2025
Merged

refactor: Polars scalar op uses singledispatchmethod #1807

merged 2 commits into from
Jun 11, 2025

Conversation

TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 10, 2025
@TrevorBergeron TrevorBergeron marked this pull request as ready for review June 10, 2025 18:23
@TrevorBergeron TrevorBergeron requested review from a team as code owners June 10, 2025 18:23
@TrevorBergeron TrevorBergeron requested a review from tswast June 10, 2025 18:23
@TrevorBergeron TrevorBergeron changed the title refactor: Refactor polars scalar op compiler refactor: Polars scalar op uses singledispatchmethod Jun 11, 2025
tswast
tswast approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator
@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@TrevorBergeron TrevorBergeron merged commit 63205f2 into main Jun 11, 2025
19 of 24 checks passed
@TrevorBergeron TrevorBergeron deleted the polars_dispatching_scalar_ops branch June 11, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees

@jialuoo jialuoo

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrevorBergeron @tswast @jialuoo
0