8000 test: run cleanup before doctest by shobsi · Pull Request #1799 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]

Skip to content

test: run cleanup before doctest #1799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

test: run cleanup before doctest #1799

merged 2 commits into from
Jun 9, 2025

Conversation

shobsi
Copy link
Contributor
@shobsi shobsi commented Jun 9, 2025

This commit changes the order of Nox sessions in the Kokoro doctest configurations to ensure that the cleanup session runs before the doctest session. This way we ensure that the failing doctest does not keep accumulating cloud artifacts and filling up quota.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

This commit changes the order of Nox sessions in the Kokoro doctest configurations to ensure that the `cleanup` session runs before the `doctest` session.
@shobsi shobsi requested a review from tswast June 9, 2025 17:04
@shobsi shobsi requested review from a team as code owners June 9, 2025 17:04
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 9, 2025
@tswast tswast enabled auto-merge (squash) June 9, 2025 17:27
@tswast tswast merged commit b7ac38e into main Jun 9, 2025
17 of 24 checks passed
@tswast tswast deleted the fix-doctest-session-order branch June 9, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0