8000 fix: allow KMeans model init parameter as k-means++ alias by GarrettWu · Pull Request #1790 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

fix: allow KMeans model init parameter as k-means++ alias #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix: allow KMeans model init parameter as k-means++ alias #1790

merged 1 commit into from
Jun 4, 2025

Conversation

GarrettWu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/421478501

@GarrettWu GarrettWu requested review from Genesis929 and shuoweil June 3, 2025 23:21
@GarrettWu GarrettWu self-assigned this Jun 3, 2025
@GarrettWu GarrettWu requested review from a team as code owners June 3, 2025 23:21
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jun 3, 2025
@GarrettWu GarrettWu merged commit 0b59cf1 into main Jun 4, 2025
22 of 24 checks passed
@GarrettWu GarrettWu deleted the garrettwu-kmeans branch June 4, 2025 17:15
@release-please release-please bot mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuoweil shuoweil shuoweil approved these changes

@Genesis929 Genesis929 Awaiting requested review from Genesis929

Assignees

@GarrettWu GarrettWu

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GarrettWu @shuoweil
0