8000 chore: add snippet tests for type system doc by sycai · Pull Request #1783 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

chore: add snippet tests for type system doc #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jun 11, 2025
Merged

chore: add snippet tests for type system doc #1783

merged 35 commits into from
Jun 11, 2025

Conversation

sycai
Copy link
Contributor
@sycai sycai commented May 30, 2025

unblock b/407575739

@product-auto-label product-auto-label bot added size: l Pull request size is 8000 large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. labels May 30, 2025
@sycai sycai marked this pull request as ready for review May 30, 2025 20:46
@sycai sycai requested review from a team as code owners May 30, 2025 20:46
@sycai sycai requested review from parthea and jialuoo May 30, 2025 20:46
@snippet-bot Snippet Bot
Copy link
snippet-bot bot commented May 30, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 11 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@sycai sycai requested review from tswast, TrevorBergeron and chelsea-lin and removed request for parthea and jialuoo May 30, 2025 20:46
tswast
tswast reviewed 8000 May 30, 2025
View reviewed changes
tswast
tswast reviewed May 30, 2025
View reviewed changes
@sycai sycai requested a review from tswast June 2, 2025 21:04
tswast
tswast reviewed Jun 5, 2025
View reviewed changes
tswast
tswast reviewed Jun 5, 2025
View reviewed changes
tswast
tswast reviewed Jun 5, 2025
View reviewed changes
@sycai sycai force-pushed the sycai_type_system_snippets branch from 815b4f1 to 74bd9e1 Compare June 10, 2025 21:35
@sycai sycai requested review from tswast and chelsea-lin June 10, 2025 21:39
tswast
tswast reviewed Jun 11, 2025
View reviewed changes
tswast
tswast reviewed Jun 11, 2025
View reviewed changes
@sycai @tswast
Update samples/snippets/type_system_test.py
d3498b4 
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
tswast
tswast reviewed Jun 11, 2025
View reviewed changes
tswast
tswast reviewed Jun 11, 2025
View reviewed changes
@sycai
Copy link
Contributor Author
sycai commented Jun 11, 2025

Removed all JSON samples as discussed. PTAL @tswast

@sycai sycai requested a review from tswast June 11, 2025 20:05
@sycai sycai merged commit e403528 into main Jun 11, 2025
17 of 24 checks passed
@sycai sycai deleted the sycai_type_system_snippets branch June 11, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@TrevorBergeron TrevorBergeron Awaiting requested review from TrevorBergeron

@GarrettWu GarrettWu Awaiting requested review from GarrettWu

@chelsea-lin chelsea-lin Awaiting requested review from chelsea-lin

Assignees

5B43 @liujiashang liujiashang

Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sycai @tswast @GarrettWu @chelsea-lin @liujiashang @bigframes-bot
0