test: Add dataframe unit test suite #1751
Conversation
34ae742 to
e8baa7d
Compare
| @@ -0,0 +1,4481 @@ | |||
| # Copyright 2023 Google LLC | |||
There was a problem hiding this comment.
Does this file contain context same as tests/system/small/test_dataframe.py? If so, can we reduce code redundancy?
There was a problem hiding this comment.
Its a slightly smaller set of tests (maybe like 80% of them?) with some slightly modified validations (eg, stop counting executions). Can unify, but goal is to eventually delete the system test versions of these tests.
5fc1913 to
4c4d939
Compare
cd89fbf to
b9c7f35
Compare
|
The unit-test coverage is decreased from 49% into 46% (link). Could you please investigate reasons. Some clues from the report: I am wondering if tests in test_dataframe_polars.py and test_local_engine.py are triggered? If not, why the report does not count them? |
89fa9b1 to
3331186
Compare
| if extras: | ||
| if install_test_extra: | ||
| if session.python in UNIT_TEST_EXTRAS_BY_PYTHON: | ||
| extras = UNIT_TEST_EXTRAS_BY_PYTHON[session.python] |
There was a problem hiding this comment.
iiuc, this branch should be like
extras = [**UNIT_TEST_EXTRAS_BY_PYTHON[session.python], **UNIT_TEST_EXTRAS].
There was a problem hiding this comment.
eh, UNIT_TEST_EXTRAS_BY_PYTHON should just be full override like for the system verison, so added 'tests' to it in new revision now
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕