8000 fix: improve robustness of managed udf code extraction by jialuoo · Pull Request #1634 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

fix: improve robustness of managed udf code extraction #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jialuoo merged 5 commits into from
Apr 22, 2025
Merged

fix: improve robustness of managed udf code extraction #1634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
44076d5
fix: improve robustness of managed udf code extraction
jialuoo Apr 18, 2025
1db54d5
resolve comments
jialuoo Apr 22, 2025
446bb32
Merge branch 'main' into fix-udf-code
jialuoo Apr 22, 2025
ba2fd65
quick fix
jialuoo Apr 22, 2025
63e0b37
Merge branch 'main' into fix-udf-code
jialuoo Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion bigframes/functions/_function_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import logging
import os
import random
import re
import shutil
import string
import tempfile
Expand Down Expand Up @@ -272,7 +273,10 @@ def provision_bq_managed_function(
# i.e. there are no references to variables or imports outside the
# body.
udf_code = textwrap.dedent(inspect.getsource(func))
udf_code = udf_code[udf_code.index("def") :]
match = re.search(r"^def ", udf_code, flags=re.MULTILINE)
if match is None:
raise ValueError("The UDF is not defined correctly.")
udf_code = udf_code[match.start() :]

with_connection_clause = (
(
Expand Down
7 changes: 6 additions & 1 deletion tests/system/large/functions/test_managed_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,12 @@ def featurize(x: int) -> list[float]:
def test_managed_function_series_apply(session, dataset_id, scalars_dfs):
try:

@session.udf(dataset=dataset_id, name=prefixer.create_prefix())
# An explicit name with "def" in it is used to test the robustness of
# the user code extraction logic, which depends on that term.
bq_name = f"{prefixer.create_prefix()}_def_to_test_code_extraction"
assert "def" in bq_name, "The substring 'def' was not found in 'bq_name'"

@session.udf(dataset=dataset_id, name=bq_name)
def foo(x: int) -> bytes:
return bytes(abs(x))

Expand Down
0