8000 feat: allow `input_types`, `output_type`, and `dataset` to be used positionally in `remote_function` by tswast · Pull Request #1560 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

feat: allow input_types, output_type, and dataset to be used positionally in remote_function #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 1 commit into from
Mar 28, 2025
Merged

feat: allow input_types, output_type, and dataset to be used positionally in remote_function #1560

tswast merged 1 commit into from
Mar 28, 2025

Conversation

@tswast
Copy link
Collaborator
@tswast tswast commented Mar 28, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 394661567 🦕

@tswast tswast requested review from a team as code owners March 28, 2025 15:26
@tswast tswast requested a review from GarrettWu March 28, 2025 15:26
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Mar 28, 2025
@tswast tswast requested a review from shobsi March 28, 2025 15:26
tswast
tswast commented Mar 28, 2025
View reviewed changes
tests/system/large/functions/test_remote_function.py
# This avoids the worst of the breaking change from 1.x to 2.x.
[int],
int,
8000 dataset=dataset_id_not_created,
Copy link
Collaborator Author
@tswast tswast Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this one, but I think it's good to have some tests with the keyword version of the parameter too.

@tswast tswast mentioned this pull request Mar 28, 2025
Merged
4 tasks
@tswast tswast merged commit bcac8c6 into main Mar 28, 2025
24 checks passed
@tswast tswast deleted the b394661567-input-output branch March 28, 2025 16:52
@release-please release-please bot mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shobsi shobsi shobsi approved these changes

@GarrettWu GarrettWu Awaiting requested review from GarrettWu GarrettWu is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@sycai sycai

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tswast @shobsi @sycai
0