8000 fix: use indexee's session for loc listlike cases by milkshakeiii · Pull Request #152 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

fix: use indexee's session for loc listlike cases #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 4 commits into from
Oct 26, 2023
Merged

fix: use indexee's session for loc listlike cases #152

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae79285
fix: use indexee's session for loc listlike cases
Oct 26, 2023
b47443a
Merge branch 'main' into b307778665-indexers-session-fix
milkshakeiii Oct 26, 2023
2f78a17
Merge branch 'main' into b307778665-indexers-session-fix
milkshakeiii Oct 26, 2023
e44a346
Merge branch 'main' into b307778665-indexers-session-fix
milkshakeiii Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions bigframes/core/indexers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,9 @@ def _loc_getitem_series_or_dataframe(
index_name = temporary_index_names[i]
values = [entry[i] for entry in key]
index_cols_dict[index_name] = values
keys_df = bigframes.dataframe.DataFrame(index_cols_dict)
keys_df = bigframes.dataframe.DataFrame(
index_cols_dict, session=series_or_dataframe._get_block().expr._session
)
keys_df = keys_df.set_index(temporary_index_names, drop=True)
keys_df = keys_df.rename_axis(original_index_names)
else:
Expand All @@ -320,7 +322,10 @@ def _loc_getitem_series_or_dataframe(
index_name_is_none = index_name is None
if index_name_is_none:
index_name = "unnamed_col"
keys_df = bigframes.dataframe.DataFrame({index_name: key})
keys_df = bigframes.dataframe.DataFrame(
{index_name: key},
session=series_or_dataframe._get_block().expr._session,
)
keys_df = keys_df.set_index(index_name, drop=True)
if index_name_is_none:
keys_df.index.name = None
Expand Down
0