8000 perf: Prune projections more aggressively by TrevorBergeron · Pull Request #1398 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

perf: Prune projections more aggressively #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrevorBergeron merged 2 commits into from
Feb 14, 2025
Merged

perf: Prune projections more aggressively #1398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f79f40
perf: Prune projections more aggressively
TrevorBergeron Feb 13, 2025
0e1091d
Merge branch 'main' into precise_projection_prune
TrevorBergeron Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions bigframes/core/rewrite/pruning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,12 +79,17 @@ def prune_selection_child(
elif isinstance(child, bigframes.core.nodes.AdditiveNode):
if not set(field.id for field in child.added_fields) & selection.consumed_ids:
return selection.replace_child(child.additive_base)
return selection.replace_child(
child.replace_additive_base(
prune_node(
child.additive_base, selection.consumed_ids | child.referenced_ids
)
needed_ids = selection.consumed_ids | child.referenced_ids
if isinstance(child, bigframes.core.nodes.ProjectionNode):
# Projection expressions are independent, so can be individually removed from the node
child = dataclasses.replace(
child,
assignments=tuple(
(ex, id) for (ex, id) in child.assignments if id in needed_ids
),
)
return selection.replace_child(
child.replace_additive_base(prune_node(child.additive_base, needed_ids))
)
elif isinstance(child, bigframes.core.nodes.ConcatNode):
indices = [
Expand Down
0