8000 chore: define timedelta type and to_timedelta function by sycai · Pull Request #1317 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

chore: define timedelta type and to_timedelta function #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sycai merged 12 commits into from
Jan 27, 2025
Merged

chore: define timedelta type and to_timedelta function #1317

sycai merged 12 commits into from
Jan 27, 2025

Conversation

@sycai
Copy link
Contributor
@sycai sycai commented Jan 23, 2025 •
edited
Loading

This change only introduces the timedelta type into the BigFrames system and makes sure the local representation looks correct.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 23, 2025
@review-notebook-app
Copy link
review-notebook-app bot commented Jan 23, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jan 23, 2025
@sycai sycai marked this pull request as ready for review January 23, 2025 19:46
@sycai sycai requested review from a team as code owners January 23, 2025 19:46
@sycai sycai requested a review from chelsea-lin January 23, 2025 19:46
@sycai sycai added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 27, 2025
@bigframes-bot bigframes-bot removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 27, 2025
@sycai sycai enabled auto-merge (squash) January 27, 2025 21:48
@sycai sycai merged commit 3901951 into main Jan 27, 2025
22 checks passed
@sycai sycai deleted the sycai_timedelta branch January 27, 2025 21:48
shuoweil pushed a commit that referenced this pull request Jan 28, 2025
@sycai @gcf-owl-bot @shuoweil
chore: define timedelta type and to_timedelta function (#1317)
160afe8 
* define timedelta type and to_timedelta function

* remove unnecessary file

* remove TypeAlias type for 3.9 compatibility

* fix mypy

* fix lint

* move timedelta out of the simple dtype list

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix type casts in tests

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

@chelsea-lin chelsea-lin Awaiting requested review from chelsea-lin chelsea-lin is a code owner automatically assigned from googleapis/api-bigquery-dataframe

@tswast tswast Awaiting requested review from tswast

Assignees

@jialuoo jialuoo

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sycai @TrevorBergeron @bigframes-bot @jialuoo
0