8000 refactor: move DDL gen to `bigframes.session._io`, add missing test by tswast · Pull Request #131 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

refactor: move DDL gen to bigframes.session._io, add missing test #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gcf-merge-on-green merged 2 commits into from
Oct 24, 2023
Merged

refactor: move DDL gen to bigframes.session._io, add missing test #131

gcf-merge-on-green merged 2 commits into from
Oct 24, 2023

Conversation

@tswast
Copy link
Collaborator
@tswast tswast commented Oct 23, 2023

Towards internal issue 280662868
🦕

@tswast tswast requested review from a team as code owners October 23, 2023 15:50
@tswast tswast requested a review from milkshakeiii October 23, 2023 15:50
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 23, 2023
@tswast tswast added the automerge Merge the pull request once unit tests and other checks pass. label Oct 24, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 386f35d into main Oct 24, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the io_bigquery branch October 24, 2023 15:44
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@milkshakeiii milkshakeiii milkshakeiii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast @milkshakeiii
0