8000 chore: test with latest sqlglot in prerelease tests by tswast · Pull Request #1283 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

chore: test with latest sqlglot in prerelease tests #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 7 commits into from
Jan 15, 2025
Merged

chore: test with latest sqlglot in prerelease tests #1283

tswast merged 7 commits into from
Jan 15, 2025

Conversation

@tswast
Copy link
Collaborator
@tswast tswast commented Jan 13, 2025

Follow-up to #1278
🦕

@tswast tswast requested review from a team as code owners January 13, 2025 19:48
@tswast tswast requested a review from Genesis929 January 13, 2025 19:48
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 13, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Jan 13, 2025
tswast
tswast commented Jan 13, 2025
View reviewed changes
@tswast
Copy link
Collaborator Author
tswast commented Jan 13, 2025

Presubmit failures appear unrelated:

FAILED tests/system/small/test_dataframe.py::test_scalar_binop[True-2.5-ne]
FAILED tests/system/small/test_dataframe.py::test_loc_bool_series - google.ap...
FAILED tests/system/small/test_dataframe.py::test_sample[frac_w_random_state]
FAILED tests/system/small/test_dataframe.py::test_scalar_binop[False-1-multiply]
FAILED tests/system/small/test_dataframe.py::test_df_idxmax - google.api_core...

All are "transient 500 errors"

@z3z1ma z3z1ma mentioned this pull request Jan 14, 2025
Merged
@Genesis929 Genesis929 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2025
@bigframes-bot bigframes-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2025
@tswast
Copy link
Collaborator Author
tswast commented Jan 14, 2025

e2e failures look like real failures:

ImportError while importing test module '/tmpfs/src/github/python-bigquery-dataframes/tests/unit/session/test_time.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/[usr/local/lib/python3.12/importlib/__init__.py:90](https://cs.corp.google.com/piper///depot/google3/usr/local/lib/python3.12/importlib/__init__.py?l=90): in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
[tests/unit/session/test_time.py:22](https://cs.corp.google.com/piper///depot/google3/tests/unit/session/test_time.py?l=22): in <module>
    import bigframes.session.time
[bigframes/__init__.py:19](https://cs.corp.google.com/piper///depot/google3/bigframes/__init__.py?l=19): in <module>
    from bigframes.core.global_session import close_session, get_global_session
[bigframes/core/__init__.py:34](https://cs.corp.google.com/piper///depot/google3/bigframes/core/__init__.py?l=34): in <module>
    import bigframes.core.nodes as nodes
[bigframes/core/nodes.py:31](https://cs.corp.google.com/piper///depot/google3/bigframes/core/nodes.py?l=31): in <module>
    from bigframes.core.ordering import OrderingExpression
[bigframes/core/ordering.py:23](https://cs.corp.google.com/piper///depot/google3/bigframes/core/ordering.py?l=23): in <module>
    import bigframes_vendored.ibis.expr.datatypes as ibis_dtypes
[third_party/bigframes_vendored/ibis/__init__.py:12](https://cs.corp.google.com/piper///depot/google3/third_party/bigframes_vendored/ibis/__init__.py?l=12): in <module>
    from bigframes_vendored.ibis import util
[third_party/bigframes_vendored/ibis/util.py:25](https://cs.corp.google.com/piper///depot/google3/third_party/bigframes_vendored/ibis/util.py?l=25): in <module>
    import toolz
E   ModuleNotFoundError: No module named 'toolz'

I suspect we stopped getting toolz as a transitive dependency at some point.

@tswast
Copy link
Collaborator Author
tswast commented Jan 14, 2025

unit_prerelease is now passing locally.

@tswast tswast merged commit a7cbf39 into main Jan 15, 2025
22 checks passed
@tswast tswast deleted the tswast-sqlglot branch January 15, 2025 16:12
shuoweil pushed a commit that referenced this pull request Jan 20, 2025
@tswast @shuoweil
chore: test with latest sqlglot in prerelease tests (#1283)
58aa6fa 
* chore: test with latest sqlglot in prerelease tests

* Update noxfile.py

* Update noxfile.py

* add vendored ibis dependencies to constraints

* update minimum typing-extensions
shuoweil pushed a commit that referenced this pull request Jan 24, 2025
@tswast @shuoweil
chore: test with latest sqlglot in prerelease tests (#1283)
724fffd 
* chore: test with latest sqlglot in prerelease tests

* Update noxfile.py

* Update noxfile.py

* add vendored ibis dependencies to constraints

* update minimum typing-extensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Genesis929 Genesis929 Genesis929 approved these changes

Assignees

@rey-esp rey-esp

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tswast @Genesis929 @bigframes-bot @rey-esp
0