8000 feat: add dataframe melt by TrevorBergeron · Pull Request #116 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@TrevorBergeron
Copy link
Contributor
@TrevorBergeron TrevorBergeron commented Oct 17, 2023

BEGIN_COMMIT_OVERRIDE
feat: Add DataFrame.melt (#113)
END_COMMIT_OVERRIDE

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@TrevorBergeron TrevorBergeron requested review from a team as code owners October 17, 2023 01:40
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 17, 2023
@TrevorBergeron TrevorBergeron requested a review from shobsi October 17, 2023 20:34
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are passing presubmit, apparently we need check_dtype=False

@TrevorBergeron TrevorBergeron requested a review from shobsi October 26, 2023 22:46
@TrevorBergeron TrevorBergeron added the automerge Merge the pull request once unit tests and other checks pass. label Oct 28, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4e4409c into main Oct 28, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the melt branch October 28, 2023 02:22
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 28, 2023
ashleyxuu pushed a commit that referenced this pull request Oct 30, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0