8000 refactor: sort the region and location in constants.py by jialuoo · Pull Request #1124 · googleapis/python-bigquery-dataframes · GitHub 8000
[go: up one dir, main page]
Skip to content

refactor: sort the region and location in constants.py #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jialuoo merged 1 commit into from
Oct 30, 2024
Merged

refactor: sort the region and location in constants.py #1124

jialuoo merged 1 commit into from
Oct 30, 2024

Conversation

@jialuoo
Copy link
Contributor
@jialuoo jialuoo commented Oct 30, 2024
  1. Sort the regions and locations so it's easier for future updates.
  2. Remove duplicate entries in BIGQUERY_REGIONS ("me-central1", "me-central2", and "me-west1").

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jialuoo jialuoo requested review from chelsea-lin and shobsi October 30, 2024 17:42
@jialuoo jialuoo self-assigned this Oct 30, 2024
@jialuoo jialuoo requested review from a team as code owners October 30, 2024 17:42
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 30, 2024
@jialuoo jialuoo merged commit cc792d2 into main Oct 30, 2024
@jialuoo jialuoo deleted the sort-region branch October 30, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shobsi shobsi shobsi approved these changes

@chelsea-lin chelsea-lin Awaiting requested review from chelsea-lin

Assignees

@jialuoo jialuoo

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jialuoo @shobsi
0