8000 chore: test fix. by Genesis929 · Pull Request #1121 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

chore: test fix. #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Genesis929 merged 2 commits into from
Oct 29, 2024
Merged

chore: test fix. #1121

Genesis929 merged 2 commits into from
Oct 29, 2024

Conversation

@Genesis929
Copy link
Collaborator
@Genesis929 Genesis929 commented Oct 29, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 29, 2024
@Genesis929 Genesis929 marked this pull request as ready for review October 29, 2024 22:29
@Genesis929 Genesis929 requested review from a team as code owners October 29, 2024 22:29
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Oct 29, 2024
@Genesis929 Genesis929 requested a review from shobsi October 29, 2024 22:30
@Genesis929 Genesis929 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 29, 2024
shobsi
shobsi reviewed Oct 29, 2024
View reviewed changes
tests/system/small/test_session.py
def test_read_gbq_on_linked_dataset_warns(session, source_table):
with warnings.catch_warnings(record=True) as warned:
session.read_gbq(source_table)
session.read_gbq(source_table, use_cache=False)
Copy link
Contributor
@shobsi shobsi Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why a cached read will trigger one extra warning?

Copy link
Collaborator Author
@Genesis929 Genesis929 Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a table is read multiple times in the same session, there will be warning messages except for the first read. And there are two tests that include step to read this table, most likely in the same session. That I think is the cause.

Check b/375664942 for details.

@Genesis929 Genesis929 enabled auto-merge (squash) October 29, 2024 23:19
@Genesis929 Genesis929 merged commit 2d3fd4b into main Oct 29, 2024
@Genesis929 Genesis929 deleted the warning_test_fix branch October 29, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shobsi shobsi shobsi left review comments

@chelsea-lin chelsea-lin chelsea-lin approved these changes

Assignees

@chelsea-lin chelsea-lin

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Genesis929 @shobsi @chelsea-lin
0