8000 fix: make `explode` respect the index labels by shobsi · Pull Request #1064 · googleapis/python-bigquery-dataframes · GitHub
[go: up one dir, main page]
Skip to content

fix: make explode respect the index labels #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shobsi merged 1 commit into from
Oct 8, 2024
Merged

fix: make explode respect the index labels #1064

shobsi merged 1 commit into from
Oct 8, 2024

Conversation

@shobsi
Copy link
Contributor
@shobsi shobsi commented Oct 8, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 372112176 🦕

@shobsi shobsi requested review from a team as code owners October 8, 2024 17:40
@shobsi shobsi requested a review from tswast October 8, 2024 17:40
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 8, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. label Oct 8, 2024
@shobsi shobsi requested a review from TrevorBergeron October 8, 2024 17:40
TrevorBergeron
TrevorBergeron approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor
@TrevorBergeron TrevorBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shobsi shobsi merged commit 99ca0df into main Oct 8, 2024
@shobsi shobsi deleted the shobs-explode-multiindex branch October 8, 2024 23:18
@release-please release-please bot mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrevorBergeron TrevorBergeron TrevorBergeron approved these changes

@tswast tswast Awaiting requested review from tswast tswast is a code owner automatically assigned from googleapis/api-bigquery-dataframe

Assignees

@TrevorBergeron TrevorBergeron

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shobsi @TrevorBergeron 320A
0