8000 chore: use 3.8 for blacken session by busunkim96 · Pull Request #653 · googleapis/python-bigquery · GitHub
[go: up one dir, main page]
Skip to content

chore: use 3.8 for blacken session #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 7, 2021
Merged

chore: use 3.8 for blacken session #653

merged 4 commits into from
May 7, 2021

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 requested review from plamut and a team May 6, 2021 14:37
@busunkim96 busunkim96 requested a review from a team as a code owner May 6, 2021 14:37
@busunkim96 busunkim96 requested review from stephaniewang526 and removed request for a team May 6, 2021 14:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 6, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 6, 2021
@tseaver
Copy link
Contributor
tseaver commented May 6, 2021

@busunkim96 I don't understand the pytype failure: it must presumably fail on master as well?

@plamut
Copy link
Contributor
plamut commented May 7, 2021 •
edited
Loading

I checked and it indeed fails on master. I wonder how that could have happened, perhaps a dependency was updated and caused this error.

Edit: And that's indeed the case, attrs==21.1.0 caused this. There's even a revert, albeit for different reasons from what I can see.

A possible workaround is to install an older version of attrs before running pytype:

session.install("attrs==20.3.0")

Edit 2: This should fix it for now. (update: merged)

@plamut plamut mentioned this pull request May 7, 2021
Merged
4 tasks
@plamut plamut added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels May 7, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 7, 2021
@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2021
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2021
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 240d1d2 into master May 7, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the busunkim96-patch-3 branch May 7, 2021 22:14
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut Awaiting requested review from plamut

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @tseaver @plamut @yoshi-kokoro
0