8000 refactor: update Job classes to use common _properties pattern by tswast · Pull Request #323 · googleapis/python-bigquery · GitHub
[go: up one dir, main page]
Skip to content

refactor: update Job classes to use common _properties pattern #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2020
Merged

refactor: update Job classes to use common _properties pattern #323

merged 2 commits into from
Oct 16, 2020

Conversation

tswast
Copy link
Contributor
@tswast tswast commented Oct 13, 2020 •
edited
Loading

Instead of mixing _properties and plain-old Python objects, always use
_properties as the source of truth.

This has the side-effect of properly reloading the whole job resource.
Previously some properties were not reloaded.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #297 🦕

@tswast
refactor: update Job classes to use common _properties pattern
59724e2 
Instead of mixing _properties and plain-old Python objects, always use
_properties as the source of truth.

This has the side-effect of properly reloading the whole job resource.
Previously some properties were not reloaded.
@tswast tswast requested a review from a team October 13, 2020 18:49
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2020
@tswast tswast mentioned this pull request Oct 13, 2020
Merged
@steffnay steffnay merged commit d093cd4 into googleapis:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@steffnay steffnay steffnay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast @steffnay
0