8000 fix: remove deepcopy while setting properties for _QueryResults by Linchin · Pull Request #2280 · googleapis/python-bigquery · GitHub
[go: up one dir, main page]
Skip to content
  • Topics
    Explore
  • Repositories
  • Available add-ons
  • Pricing

    • Search code, repositories, users, issues, pull requests...

    Provide feedback

    We read every piece of feedback, and take your input very seriously.

    Saved searches

    Use saved searches to filter your results more quickly
    Appearance settings

    fix: remove deepcopy while setting properties for _QueryResults #2280

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Merged
    merged 1 commit into from
    Sep 6, 2025
    Merged

    fix: remove deepcopy while setting properties for _QueryResults #2280

    merged 1 commit into from
    Sep 6, 2025

    Conversation

    Linchin
    Copy link
    Contributor
    @Linchin Linchin commented Sep 5, 2025 •
    edited
    Loading

    See internal issue 442629997

    This deepcopy() is causing memory spike when people call Client.query_and_wait().

    Fixes #2279 🦕

    @Linchin Linchin requested review from a team as code owners September 5, 2025 21:01
    @Linchin Linchin requested a review from leahecole September 5, 2025 21:01
    @product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 5, 2025
    @product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 5, 2025
    tswast
    tswast approved these changes Sep 6, 2025
    View reviewed changes
    Copy link
    Contributor
    @tswast tswast left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thanks!

    @tswast tswast merged commit 33ea296 into googleapis:main Sep 6, 2025
    24 checks passed
    @release-please release-please bot mentioned this pull request Sep 4, 2025
    Merged
    This was referenced Sep 16, 2025
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @tswast tswast tswast approved these changes

    @leahecole leahecole Awaiting requested review from leahecole leahecole is a code owner automatically assigned from googleapis/api-bigquery

    Assignees

    @tswast tswast

    Labels

    api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    Memory spike caused by deepcopy in _QueryResult

    2 participants

    @Linchin @tswast
    0