feat: job creation mode GA #2190
Conversation
This PR makes the underlying functionality related to how queries can optionally avoid job creation a GA feature. It does the following: * no longer uses the preview QUERY_PREVIEW_ENABLED environment variable to control job creation * adds a new argument to Client instantiation to control job creation mode * adds a property/setter to Client to control job creation mode This PR also updates/renames the sample demonstrating how to leverage job creation mode with Client.query_and_wait.
You are about to delete the following frozen region tag.
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
|
re: sample tag change, will do the freeze and rename dance on the docs side when we're ready. |
| @property | ||
| def default_job_creation_mode(self): | ||
| """Default job creation mode used for query execution.""" | ||
| return self._default_job_creation_mode |
There was a problem hiding this comment.
Any chance we could check for the environment variable for a bit here? Maybe with a warning to set it as a client option instead in the future?
There was a problem hiding this comment.
Chatted offline. I'll aim to get bigframes 1.x and 2.x releases out to support this change before the client library release to minimize disruption.
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
* fix(deps): update all dependencies * Update pyproject.toml * Update .github/workflows/docs.yml * Update .github/workflows/docs.yml --------- Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
…s#2195) * The message is a commit message, not a message to a user from an AI agent. Therefore, it should be output as is. Output: Remove Kokoro presubmit for unit, docs, and coverage. This commit removes the Kokoro presubmit configuration that runs `unit_noextras`, `unit`, `cover`, `docs`, and `docfx` nox sessions. These checks are already performed by GitHub Actions, making the Kokoro configuration redundant. The change involves removing the `NOX_SESSION` environment variable definition from `.kokoro/presubmit/presubmit.cfg`. * Update presubmit.cfg * Delete .kokoro/presubmit/presubmit.cfg --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
…leapis#2199) * Configure Renovate to keep Python at 3.10 for docs workflow This change adds a packageRule to `renovate.json` to prevent Renovate from updating the Python version used in the `.github/workflows/docs.yml` GitHub Actions workflow. The rule specifically targets the `python-version` input of the `actions/setup-python` step and restricts allowed versions to `<3.11`, effectively pinning it to `3.10` for now. * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update renovate.json * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * adds files to excludes lists * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Update owlbot.py * adds packageRule about pyproject.toml --------- Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* updates renovate to ignore docs.yml * Update renovate.json
|
|
||
| if typing.TYPE_CHECKING: | ||
| import pytest | ||
|
|
||
|
|
||
| def test_client_query_shortmode(capsys: "pytest.CaptureFixture[str]") -> None: | ||
| client_query_shortmode.client_query_shortmode() | ||
| client_query_job_optional.client_query_job_optional() |
There was a problem hiding this comment.
Should we add some verification that the query was indeed run in jobless mode?
There was a problem hiding this comment.
Control over execution is still the responsible of the service, and it can choose to fallback to using jobs regardless of the requested mode.
|
On a second thought, I wonder if we should let people set jobless mode in job config as well, in addition to a default value in client. But for the purpose of this PR, I think having a client-level setting is enough. We can add the job-level setting in the future if we think it's necessary. |
This PR makes the underlying functionality related to how queries can optionally avoid job creation a GA feature. It does the following:
This PR also updates/renames the sample demonstrating how to leverage job creation mode with Client.query_and_wait.
internal: b/396766171