8000 feat(bigquery): add client_options to base class by HemangChothani · Pull Request #216 · googleapis/python-bigquery · GitHub
[go: up one dir, main page]
Skip to content

feat(bigquery): add client_options to base class #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2020
Merged

feat(bigquery): add client_options to base class #216

merged 3 commits into from
Aug 14, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #178 🦕

@HemangChothani HemangChothani requested a review from plamut August 10, 2020 07:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2020
@tseaver
Copy link
Contributor
tseaver commented Aug 10, 2020

Docs build broke due to Sphinx 3.2.0 release. See #217 / PR #218.

@tseaver
Copy link
Contributor
tseaver commented Aug 10, 2020

@HemangChothani PR #218 has landed, fixing the docs session (#217). You'll need to merge master yourself (the PR branch is blocked for maintainer edits / merges).

busunkim96
busunkim96 reviewed Aug 12, 2020
View reviewed changes
setup.py Outdated
'enum34; python_version < "3.4"',
"google-api-core >= 1.21.0, < 2.0dev",
"google-cloud-core >= 1.1.0, < 2.0dev",
"google-cloud-core >= 1.4.0, < 2.0dev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"google-cloud-core >= 1.4.0, < 2.0dev",
"google-cloud-core >= 1.4.1, < 2.0dev",

@HemangChothani HemangChothani merged commit 478597a into googleapis:master Aug 14, 2020
@release-please release-please bot mentioned this pull request Jan 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plamut plamut Awaiting requested review from plamut

2 more reviewers

@tseaver tseaver tseaver approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement new client options

3 participants

@HemangChothani @tseaver @busunkim96
0