8000 fix: correct type checking by Linchin · Pull Request #1848 · googleapis/python-bigquery · GitHub
[go: up one dir, main page]
Skip to content

fix: correct type checking #1848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 11, 2024
Merged

fix: correct type checking #1848

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f778362
fix: correct type checking
Linchin Mar 8, 2024
081267d
Update google/cloud/bigquery/job/query.py
chalmerlowe Mar 11, 2024
88b4a2f
Merge branch 'main' into type-check-1838
chalmerlowe Mar 11, 2024
ecb6ae1
Merge branch 'main' into type-check-1838
gcf-merge-on-green[bot] Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/bigquery/job/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1409,9 +1409,9 @@ def _reload_query_results(
# Python_API_core, as part of a major rewrite of the deadline, timeout,
# retry process sets the timeout value as a Python object().
# Our system does not natively handle that and instead expects
# either none or a numeric value. If passed a Python object, convert to
# either None or a numeric value. If passed a Python object, convert to
# None.
if isinstance(self._done_timeout, object): # pragma: NO COVER
if type(self._done_timeout) is object: # pragma: NO COVER
self._done_timeout = None

if self._done_timeout is not None: # pragma: NO COVER
Expand Down
0