8000 fix: keep `RowIterator.total_rows` populated after iteration by tswast · Pull Request #1748 · googleapis/python-bigquery · GitHub
[go: up one dir, main page]
Skip to content

fix: keep RowIterator.total_rows populated after iteration #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix: keep RowIterator.total_rows populated after iteration #1748

merged 2 commits into from
Dec 8, 2023

Conversation

tswast
Copy link
Contributor
@tswast tswast commented Dec 8, 2023

Split out of #1722

This was being reset in some cases when the rows were all available in the first page of results.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #589 🦕

@tswast
fix: keep RowIterator.total_rows populated after iteration
f08dac3 
This was being reset in some cases when
the rows were all available in the
first page of results.
@tswast tswast requested review from a team as code owners December 8, 2023 02:01
@tswast tswast requested a review from chalmerlowe December 8, 2023 02:01
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 8, 2023
@tswast
Copy link
Contributor Author
tswast commented Dec 8, 2023

Alternatively, we could populate totalRows here if present:

python-bigquery/google/cloud/bigquery/table.py

Line 1703 in ab73796

response = {

Not sure which to prefer, but this way involved updating fewer tests.

@tswast tswast mentioned this pull request Dec 8, 2023
Closed
parthea
parthea approved these changes Dec 8, 2023
View reviewed changes
@tswast @parthea
Update google/cloud/bigquery/table.py
a376bd6 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@tswast tswast enabled auto-merge (squash) December 8, 2023 21:36
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2023
@tswast tswast merged commit 8482f47 into main Dec 8, 2023
@tswast tswast deleted the issue589-total_rows branch December 8, 2023 22:13
@release-please release-please bot mentioned this pull request Dec 8, 2023
Merged
This was referenced Dec 19, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe chalmerlowe is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide support for synchronous queries through the v2/projects/{projectId}/queries endpoint
3 participants
@tswast @parthea @yoshi-kokoro
0