E5FD fix: AccessEntry API representation parsing by jonathan-ostrander · Pull Request #1682 · googleapis/python-bigquery · GitHub
[go: up one dir, main page]
Skip to content

fix: AccessEntry API representation parsing #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 19, 2023
Merged

fix: AccessEntry API representation parsing #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce36b9f
fix: AccessEntry API representation parsing
jonathan-ostrander Oct 13, 2023
15153e6
build: formatting
jonathan-ostrander Oct 18, 2023
9bad956
Merge branch 'main' into access_entry_repr_fix
jonathan-ostrander Oct 18, 2023
3ae5a83
Merge branch 'main' into access_entry_repr_fix
Linchin Oct 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions google/cloud/bigquery/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,9 +501,7 @@ def from_api_repr(cls, resource: dict) -> "AccessEntry":
if len(entry) != 0:
raise ValueError("Entry has unexpected keys remaining.", entry)

config = cls(role, entity_type, entity_id)
config._properties = copy.deepcopy(resource)
return config
return cls(role, entity_type, entity_id)


class Dataset(object):
Expand Down
16 changes: 16 additions & 0 deletions tests/unit/test_dataset.py
View file
Open in desktop 89D2
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,22 @@ def test_from_api_repr_w_unknown_entity_type(self):
exp_resource = entry.to_api_repr()
self.assertEqual(resource, exp_resource)

def test_from_api_repr_wo_role(self):
resource = {
"view": {
"projectId": "my-project",
"datasetId": "my_dataset",
"tableId": "my_table",
}
}
entry = self._get_target_class().from_api_repr(resource)
exp_entry = self._make_one(
role=None,
entity_type="view",
entity_id=resource["view"],
)
self.assertEqual(entry, exp_entry)

def test_to_api_repr_w_extra_properties(self):
resource = {
"role": "READER",
Expand Down
0