8000 fix: filter None values from OpenTelemetry attributes by galz10 · Pull Request #1567 · googleapis/python-bigquery · GitHub
[go: up one dir, main page]
Skip to content

fix: filter None values from OpenTelemetry attributes #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 18, 2023
Merged

fix: filter None values from OpenTelemetry attributes #1567

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1342af0
fix: filter None values from OpenTelemetry attributes
galz10 May 16, 2023
1bd3e84
Merge branch 'main' into issue1385-fix
galz10 May 18, 2023
19edf97
moved filtering out before return value
galz10 May 18, 2023
38da8ca
Merge branch 'issue1385-fix' of https://github.com/galz10/python-bigq…
galz10 May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions google/cloud/bigquery/opentelemetry_tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ def _get_final_span_attributes(attributes=None, client=None, job_ref=None):
final_attributes.update(job_attributes)
if attributes:
final_attributes.update(attributes)

filtered = {k: v for k, v in final_attributes.items() if v is not None}
final_attributes.clear()
final_attributes.update(filtered)

return final_attributes


Expand Down
0