8000 feat: add preserveAsciiControlCharacter to LoadJobConfig by Mattix23 · Pull Request #1484 · googleapis/python-bigquery · GitHub
[go: up one dir, main page]
Skip to content

feat: add preserveAsciiControlCharacter to LoadJobConfig #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2023
Merged

feat: add preserveAsciiControlCharacter to LoadJobConfig #1484

merged 1 commit into from
Jan 31, 2023

Conversation

Mattix23
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Closes #1387 🦕

@Mattix23 Mattix23 requested a review from a team January 31, 2023 17:40
@Mattix23 Mattix23 requested a review from a team as a code owner January 31, 2023 17:40
@Mattix23 Mattix23 requested a review from prash-mi January 31, 2023 17:40
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 31, 2023
@Mattix23 Mattix23 enabled auto-merge (squash) January 31, 2023 17:48
@Mattix23 Mattix23 merged commit bd1da9a into main Jan 31, 2023
@Mattix23 Mattix23 deleted the issue1387_preserve_ascii_mtorresjr branch January 31, 2023 18:06
@release-please release-please bot mentioned this pull request Jan 31, 2023
Merged
This was referenced Feb 7, 2023
Closed
Closed
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@Mattix23 @abdelmegahedgoogle
feat: add preserveAsciiControlCharacter to LoadJobConfig (googleapis#…
815a02d 
…1484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

@prash-mi prash-mi Awaiting requested review from prash-mi

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

option to set preserve_ascii_control_characters is not available on load config

2 participants

@Mattix23 @tswast
0