8000 fix: display export format id in error message by emmanuel-ferdman · Pull Request #5279 · googleapis/python-aiplatform · GitHub
[go: up one dir, main page]
Skip to content

fix: display export format id in error message #5279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix: display export format id in error message #5279

wants to merge 3 commits into from

Conversation

emmanuel-ferdman
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Get the necessary approvals
  • Once the last commit on the PR has been approved, add the "ready to pull" label to the Pull Request

PR Summary

This small PR evaluates the export format id in error message of google/cloud/aiplatform/models.py. It also fixes a few typos along the way.

@emmanuel-ferdman
fix: display export format id in error message
e496555 
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Apr 30, 2025
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 30, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 30, 2025
@jaycee-li jaycee-li added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 8, 2025
@jaycee-li jaycee-li added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 15, 2025
@parthea parthea requested a review from sasha-gitg June 19, 2025 16:33
@sasha-gitg
Copy link
Member

This is making changes to an auto-generated file so we cannot accept this change: https://github.com/googleapis/python-genai/blob/main/google/genai/models.py#L16

@sasha-gitg sasha-gitg closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg Awaiting requested review from sasha-gitg

Assignees

@sasha-gitg sasha-gitg

Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emmanuel-ferdman @sasha-gitg @parthea @yoshi-kokoro @jaycee-li
0