8000 for testing purposes by parthea · Pull Request #523 · googleapis/proto-plus-python · GitHub
[go: up one dir, main page]
Skip to content

for testing purposes #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

for testing purposes #523

wants to merge 1 commit into from

Conversation

parthea
Copy link
Contributor
@parthea parthea commented Jan 22, 2025

Prototyping for #521

@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 22, 2025
@parthea parthea force-pushed the pypy-presubmit branch 6 times, most recently from f3f6a66 to ef56bf0 Compare January 22, 2025 11:42
@parthea
Copy link
Contributor Author
parthea commented Jan 22, 2025 •
edited
Loading

In PyPy3.10, we see the following warnings

upb

UserWarning: Selected implementation upb is not available. Falling back to the python implementation.

nox > pytest --quiet --cov=proto --cov-config=.coveragerc --cov-report=term --cov-report=html tests
ImportError while loading conftest '/home/runner/work/proto-plus-python/proto-plus-python/tests/conftest.py'.
tests/conftest.py:18: in <module>
    from google.protobuf import descriptor_pool
.nox/unit-pypy3-10-implementation-upb/lib/pypy3.10/site-packages/google/protobuf/descriptor_pool.py:41: in <module>
    from google.protobuf import descriptor
.nox/unit-pypy3-10-implementation-upb/lib/pypy3.10/site-packages/google/protobuf/descriptor.py:20: in <module>
    from google.protobuf.internal import api_implementation
.nox/unit-pypy3-10-implementation-upb/lib/pypy3.10/site-packages/google/protobuf/internal/api_implementation.py:100: in <module>
    warnings.warn('Selected implementation upb is not available. '
E   UserWarning: Selected implementation upb is not available. Falling back to the python implementation.

cpp

UserWarning: PyPy does not work yet with cpp protocol buffers. Falling back to the python implementation.

nox > pytest --quiet --cov=proto --cov-config=.coveragerc --cov-report=term --cov-report=html tests
ImportError while loading conftest '/home/runner/work/proto-plus-python/proto-plus-python/tests/conftest.py'.
tests/conftest.py:[18](https://github.com/googleapis/proto-plus-python/actions/runs/12907499279/job/35991059988?pr=523#step:5:19): in <module>
    from google.protobuf import descriptor_pool
.nox/unit-pypy3-10-implementation-cpp/lib/pypy3.10/site-packages/google/protobuf/descriptor_pool.py:63: in <module>
    from google.protobuf import descriptor
.nox/unit-pypy3-10-implementation-cpp/lib/pypy3.10/site-packages/google/protobuf/descriptor.py:40: in <module>
    from google.protobuf.internal import api_implementation
.nox/unit-pypy3-10-implementation-cpp/lib/pypy3.10/site-packages/google/protobuf/internal/api_implementation.py:65: in <module>
    warnings.warn('PyPy does not work yet with cpp protocol buffers. '
E   UserWarning: PyPy does not work yet with cpp protocol buffers. Falling back to the python implementation.
nox > Command pytest --quiet --cov=proto --cov-config=.coveragerc --cov-report=term --cov-report=html tests failed with exit code 4
nox > Session unit-pypy3.10(implementation='cpp') failed.

@parthea parthea mentioned this pull request Jan 22, 2025
Closed
@parthea
Copy link
Contributor Author
parthea commented Jan 22, 2025

The failure below should be fixed with #507

https://github.com/googleapis/proto-plus-python/actions/runs/12907548308/job/35991217125?pr=523

            else:  # Python 3.11.0b3
>               del attrs._member_names[pb_options]
E               TypeError: 'set' object does not support item deletion

proto/enums.py:65: TypeError

Closing this PR. I'll incorporate the new PyPy presubmit into the existing PR #507

@parthea parthea closed this Jan 22, 2025
@parthea parthea mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@parthea
0